Fixed TED opens new edit tab for file that is already open on errors and debug stop.

[dawlane]

TED has an intermittent habit of opening a new edit tab for a file that is already open in the editor when a code error or debug stop is detected.

I suspect that the problem lies within MainWindow:: openFile and with it calling MainWindow::editorWithPath.

This is on Linux and I will have to test the others operating systems.

 

[dawlane]

OK looks like it's not a bug but a system path error with how a system is set up. System links are not being followed or are not taken into account in TED. Why I never noticed this before is beyond me, it shows the file path in the window title.

Example: You have two hard drives installed. Hard drive one is has the operating system and the user home directories, hard drive two holds your development files. Hard drive two is mounted in /mnt under the directory name dev, but you have a link in your home directory to this directory, so the paths would be /mnt/dev and /home/user/dev. This mean that if you open a file in TED via the home directory link (/home/user/dev) the path stored is different from what is being returned by transcc (/mnt/dev).

May be able to fix this some how with using QFileInfo::canonicalFilePath().

 

[MikeHart]

Still sounds like a bug to me, or?

 

[dawlane]

More like an over-site on Mark's side. I take that when TED was written Mark didn't give much thought to how file paths could be handled on a system, after all, system links are not that common on your average Windows users system. So it could be mark down as a bug.

I'm currently having a look to see if I can find a suitable solution of converting the paths where QFile are used.

 

[dawlane]

Well the fix on Linux is simple enough.
In file mainwindow.cpp add

path = QFileInfo(path).canonicalFilePath();

in both the member functions before any method that sends a path to the class CodeEditor:

QWidget *newFile( const QString &path );

after the file.close(); and before the if statement.

QWidget *openFile( const QString &path,bool addToRecent );

after the if( path.isEmpty) block and before CodeEditor *editor=editorWithPath( path );

I haven't test this with Windows or OS X yet. Having trouble with getting a version of Qt that supports Webkit working.

 

[MikeHart]

Having trouble with getting a version of Qt that supports Webkit working.

Martin used 5.5.1 to compile Ted. But he used the visual Studio version I think.

 

[dawlane]

Martin used 5.5.1 to compile Ted.

I though he used 5.6.2? I'll give VS a go.

 

[MikeHart]

He told me he uses 5.5 1

 

[Martin]

Actually I used 5.5.1 because this version was the latest using webkit stuff.

 

[dawlane]

Just checked with the current version of Ted on Windows: QT_VERSION 0x050501, so 5.5.1 it is.
It's taken me longer to install Qt on Windows than for either Linux or OS X. And by the looks of it symbolic links are behaving normally without the use of canonicalFilePath, which has no affect. So Windows API's must be resolving links.

Next test OS X

 

[dawlane]

So far all OS's appear to be working correctly with file handling, apart from opening a directory alias in OS X as a project. Must have something to do with this

QFileDialog::dontResolveSymlinks

flag being passed in MainWindow onBuildAddProject(), as removing it allows an alias to be resolved correctly instead of loading it into the code editor. Whether this removal causes problems with the other OS's has to be checked.

 

[MikeHart]

@dawlane : Was this fix ever submitted to the repository?

 

[MikeHart]

@dawlane, is this still an issue in the official version?

Btw. could you please produce a distribution of 2018-12-30?

 

[dawlane]

New Linux 64 build of Cerberus-2018-12-30 compiled on Linux Mint 18.3 (Sylvia).

is this still an issue in the official version?

Yes the bug is still in there. I will have to have a look from one of my old ted files to see where I originally made the changes to fix it and post a patch file.

 

[dawlane]

OK instead of a patch file a quick fix that so far seems to work.

In the file mainwindow.cpp:

In method implementation (around line 551)

QWidget *MainWindow::newFile( const QString &cpath )

change

file.close();

    if( CodeEditor *editor=editorWithPath( path ) ) closeFile( editor );

to

    file.close();

/* DAWLANE LINUX SYSLINK PATH FIX
* If symbolic links are use, the IDE will try to open a new editor on an error.
* This fix sets the path to the full path of the actual target file.
*/
#ifdef Q_OS_LINUX
    path = QFileInfo(path).canonicalFilePath();
#endif

    if( CodeEditor *editor=editorWithPath( path ) ) closeFile( editor );

In the method implementation (around line 665)

QWidget *MainWindow::openFile( const QString &cpath,bool addToRecent )

change

    if (isDocFile(path)) {
        showDoc(path);
        return nullptr;
    }

    CodeEditor *editor=editorWithPath( path );

to

    if (isDocFile(path)) {
        showDoc(path);
        return nullptr;
    }

/* DAWLANE LINUX SYSLINK PATH FIX
* If symbolic links are use, the IDE will try to open a new editor on an error.
* This fix sets the path to the full path of the actual target file.
*/
#ifdef Q_OS_LINUX
    path = QFileInfo(path).canonicalFilePath();
#endif

    CodeEditor *editor=editorWithPath( path );

In the method implementation (around line 589)

QWidget *MainWindow::newFileTemplate( const QString &cpath )

change

if( !file.open( QIODevice::ReadOnly ) ){
        QMessageBox::warning( this,"New file","Failed to create new file from template: "+path );
        return nullptr;
    }

    file.close();

    if( CodeEditor *editor=editorWithPath( path ) ) closeFile( editor );

to

    if( !file.open( QIODevice::ReadOnly ) ){
        QMessageBox::warning( this,"New file","Failed to create new file from template: "+path );
        return nullptr;
    }

    file.close();
/* DAWLANE LINUX SYSLINK PATH FIX
* If symbolic links are use, the IDE will try to open a new editor on an error.
* This fix sets the path to the full path of the actual target file.
*/
#ifdef Q_OS_LINUX
    path = QFileInfo(path).canonicalFilePath();
#endif
    if( CodeEditor *editor=editorWithPath( path ) ) closeFile( editor );

 

[MikeHart]

Thank you. I asked because on Windows I never saw this behavior.

 

[dawlane]

I asked because on Windows I never saw this behavior.

Links are hardly ever used on Windows with such things needing elevated privileges to create them. But Linux and Mac OSX (to a certain point) allow user created links. The last time I messed around with Ted and Mac OSX folder alias links, Ted tried to open the folder alias for editing in the editor.
I think that QDirIterator::FollowSymlinks had to be set, but if I recall care had to be taken with alias to files as Qt of the day could remove the actual file and not the alias.

 

[MikeHart]

Fix is on GitHub.